Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECOSYSTEM.md about Shuttle #2305

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Nov 8, 2023

Motivation

Shuttle has out-of-the-box support for Axum and it makes hosting Axum projects easier for the users.

Actix Web docs also has a separate section that mentions Shuttle: https://actix.rs/docs/shuttle

I thought it would be nice to add it to Axum as well.

Solution

This PR adds a new example called shuttle-service for demonstrating how to create a Axum project and deploying it on the Shuttle platform.

Additionally, updated the outdated Shuttle reference in ECOSYSTEM.md and added another example.

I also added a separate section to README.md for listing possible hosting solutions.

@davidpdrsn
Copy link
Member

Thanks for the PR though I don't think we can feature shuttle quite this prominently.

I think linking to stuff from ECOSYSTEM.md is fine but I don't think we should have a shuttle specific example or mention it in the readme. It feels too much like an official endorsement from tokio which I don't think is appropriate.

@orhun orhun changed the title Add hosting instructions/example for Shuttle Update ECOSYSTEM.md about Shuttle Nov 8, 2023
@orhun
Copy link
Contributor Author

orhun commented Nov 8, 2023

Got it, reasonable. Updated the PR!

Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidpdrsn davidpdrsn merged commit 3ff45d9 into tokio-rs:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants