refactor deprecated Cookie::named fn #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good timing, given we're pretty close to releasing a breaking-change version and this is a public dependency! :) |
jplatte
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
The cookie crate's changelog mentions that it now uses impl Into<Cookie> in many places. I think we should copy that design, but we can merge this PR first and do a follow-up. wdyt @davidpdrsn?
Closed
Good idea! I've filed #2347 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cookie crate is now at version 0.18
In its changelog i see a deprecated fn and after doing cargo test i saw that Cookie::named could be now substituted by cookie::from or cookie::build