feat: local_addr for Serve and WithGracefulShutdown #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds methods for exposing the address the Axum servers are bound to. * add `Serve::local_addr` * add `WithGracefulShutdown::local_addr` Implements tokio-rs#2879
|
Could you please add a change log entry though? |
|
@jplatte that is added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods for exposing the address the Axum servers are bound to.
Serve::local_addr, which returns the address it is bound to.WithGracefulShutdown::local_addr, which returns the address it is bound to.Closes #2879
Motivation
I would like to be able to know the address of a server, as it makes testing code easier to write.
Solution
I have added methods to expose the
SocketAddronServeandWithGracefulShutdown.