Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter path deserialization for tuples and tuple structs #2931

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

LHolten
Copy link
Contributor

@LHolten LHolten commented Sep 24, 2024

Fixes #2930
Motivation and solution as proposed in that issue.

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

axum/CHANGELOG.md Outdated Show resolved Hide resolved
@jplatte jplatte enabled auto-merge (squash) September 24, 2024 17:11
@jplatte
Copy link
Member

jplatte commented Sep 24, 2024

Side note: It appears that the email you have configured git to use as part of your author identity is not one that you told GitHub about, which is why the commits here are not linked to your profile.

The squashed commit that will be merged will be associated to your profile though, since GitHub uses the PR author's primary email for this (a gmail address in this case). If that's a problem for you, let me know (even if already merged).

@jplatte jplatte merged commit 4179d11 into tokio-rs:main Sep 24, 2024
18 checks passed
@LHolten
Copy link
Contributor Author

LHolten commented Sep 24, 2024

Thanks for the note! I don't mind that it used my primary email, but I will try to add the second email to be associated with my account.

Lachstec pushed a commit to Lachstec/axum that referenced this pull request Oct 11, 2024
Lachstec pushed a commit to Lachstec/axum that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that number of path parameters matches tuple path extractor exactly
2 participants