core: Fix compile errors from __log_rejection #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was failing to compile if axum-core's tracing feature was enabled, but the tracing feature of axum or axum-extra wasn't when those were part of the dependency tree.
mladedav
approved these changes
Sep 25, 2024
jplatte
added a commit
that referenced
this pull request
Sep 27, 2024
Lachstec
pushed a commit
to Lachstec/axum
that referenced
this pull request
Oct 11, 2024
Lachstec
pushed a commit
to Lachstec/axum
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It was failing to compile if axum-core's tracing feature was enabled, but the tracing feature of axum or axum-extra wasn't when those were part of the dependency tree.
Solution
Use a private re-export, as commonly done with macros that need to refer to some other crate at the expansion site.
Fixes #2932.