Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove raw string hashes #3071

Merged
merged 2 commits into from
Dec 9, 2024
Merged

refactor: remove raw string hashes #3071

merged 2 commits into from
Dec 9, 2024

Conversation

hamirmahal
Copy link
Contributor

Closes #3070

Motivation

There are some unnecessary # symbols we can remove to make axum/src/extract/path/mod.rs a bit cleaner and improve code readability and maintainability.

Solution

We remove the unnecessary # symbols.

hamirmahal
hamirmahal commented Dec 8, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a small refactor to improve code readability. It shouldn't result in any user-facing changes.

jplatte
jplatte approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these also don't need to be raw string literals in general, right?

@hamirmahal
Copy link
Contributor Author

Ah, I think you're right.

@jplatte jplatte merged commit fd11d8e into tokio-rs:main Dec 9, 2024
18 checks passed
@hamirmahal hamirmahal deleted the refactor/remove-raw-string-hashes-that-are-unnecessary branch December 9, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

axum/src/extract/path/mod.rs has some unnecessary # symbols
2 participants
@hamirmahal @jplatte