Change error type for RequestParts::try_into_request
#639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Dec 18, 2021
There was a problem hiding this comment.
I think it's fine to remove the crate-internal downcast function.
Since this is a breaking change, I don't think it can be merged into main now. @davidpdrsn do you want to create a next / 0.5-pre or similar branch that breaking-change PRs can go to?
|
Yeah I think we can just remove the method. It's in git if we need it back.
I'll make a branch that we can merge breaking changes into. I'll do that next week and then can we merge this branch into that. |
davidpdrsn
approved these changes
Dec 21, 2021
davidpdrsn
pushed a commit
that referenced
this pull request
Dec 27, 2021
davidpdrsn
pushed a commit
that referenced
this pull request
Jan 3, 2022
davidpdrsn
pushed a commit
that referenced
this pull request
Jan 3, 2022
davidpdrsn
pushed a commit
that referenced
this pull request
Jan 23, 2022
davidpdrsn
pushed a commit
that referenced
this pull request
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #632.
I'm not sure if
Error::downcastshould be removed or not as it was only used intry_into_request, so for now I marked it with#[allow(dead_code)]