Add trait IntoResponseHeaders #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to the new blanket impl of |
jplatte
force-pushed
the
into-response-headers-2
branch
2 times, most recently
from
d431567
to
e0ee388
Compare
davidpdrsn
force-pushed
the
axum-next
branch
from
7bac03b
to
b9e4c5e
Compare
davidpdrsn
reviewed
Dec 27, 2021
jplatte
force-pushed
the
into-response-headers-2
branch
from
e0ee388
to
6b5d3b2
Compare
|
I think it makes sense to deal with the proposed This one is useful as-is. |
jplatte
force-pushed
the
into-response-headers-2
branch
from
6b5d3b2
to
f684eee
Compare
davidpdrsn
force-pushed
the
axum-next
branch
2 times, most recently
from
f04cf94
to
a7de04f
Compare
|
Sorry for taking so long to review this. Hoping to get to it this weekend. |
… and update IntoResponse impls that use HeaderMap to be generic instead.
… and remove IntoResponse impls that use it.
jplatte
force-pushed
the
into-response-headers-2
branch
from
f684eee
to
520c42d
Compare
|
Rebased. |
davidpdrsn
approved these changes
Jan 23, 2022
davidpdrsn
pushed a commit
that referenced
this pull request
Jan 23, 2022
* Introduce IntoResponseHeaders trait * Implement IntoResponseHeaders for HeaderMap * Add impl IntoResponse for impl IntoResponseHeaders … and update IntoResponse impls that use HeaderMap to be generic instead. * Add impl IntoResponseHeaders for Headers … and remove IntoResponse impls that use it. * axum-debug: Fix grammar in docs * Explain confusing error message in docs
davidpdrsn
pushed a commit
that referenced
this pull request
Jan 23, 2022
* Introduce IntoResponseHeaders trait * Implement IntoResponseHeaders for HeaderMap * Add impl IntoResponse for impl IntoResponseHeaders … and update IntoResponse impls that use HeaderMap to be generic instead. * Add impl IntoResponseHeaders for Headers … and remove IntoResponse impls that use it. * axum-debug: Fix grammar in docs * Explain confusing error message in docs
davidpdrsn
pushed a commit
that referenced
this pull request
Jan 23, 2022
* Introduce IntoResponseHeaders trait * Implement IntoResponseHeaders for HeaderMap * Add impl IntoResponse for impl IntoResponseHeaders … and update IntoResponse impls that use HeaderMap to be generic instead. * Add impl IntoResponseHeaders for Headers … and remove IntoResponse impls that use it. * axum-debug: Fix grammar in docs * Explain confusing error message in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It would be nice to be able to return
TypedHeaderin the same positions asHeaders<_>, but that doesn't work without moving it intoaxum-coredue to coherence and that would be very unfortunate. Also,Headersonly lives inaxum-coredue to the same coherence issues.Solution
Introduce a new trait
IntoResponseHeadersand implement it forHeaderMapandHeaders. MoveHeadersinto axum.Notes
I think this is all of the hard stuff dealt with. It should now be straight-forward to
move(done), implementHeadersinto axumIntoResponseHeadersforTypedHeaderand move it into its own module (outsideresponse) / re-export it from theaxumcrate root likeJsonand addIntoResponseimpls for tuples with moreIntoResponseHeadersitems.