Remove RequestParts::take_extensions
#699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jan 11, 2022
Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com>
jplatte
approved these changes
Jan 11, 2022
davidpdrsn
added a commit
that referenced
this pull request
Jan 23, 2022
* Remove `RequestParts::take_extensions` * fix out of date docs * Remove RequestAlreadyExtracted and replace it with BodyAlreadyExtracted * fix docs * fix test * Update axum-core/src/extract/mod.rs Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com> * Remove macro only used once Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com>
davidpdrsn
added a commit
that referenced
this pull request
Jan 23, 2022
* Remove `RequestParts::take_extensions` * fix out of date docs * Remove RequestAlreadyExtracted and replace it with BodyAlreadyExtracted * fix docs * fix test * Update axum-core/src/extract/mod.rs Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com> * Remove macro only used once Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same story as #698 but this time for extensions.
Removes
RequestParts::take_extensionsandimpl FromRequest for ExtensionsmeaningExtensionsis no longer an extractor. Been thinking before that it probably didn't have much utility in the first place since all you can do isgettypes, whichextract::Extensioncan also do. Users can still useRequestParts::extensions_muthowever tostd::mem::takethem if they really need to.TODO