Set Allow header when returning 405 Method Not Allowed
#733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
approved these changes
Jan 30, 2022
davidpdrsn
added a commit
that referenced
this pull request
Jan 31, 2022
davidpdrsn
added a commit
that referenced
this pull request
Feb 22, 2022
davidpdrsn
added a commit
that referenced
this pull request
Feb 22, 2022
davidpdrsn
added a commit
that referenced
this pull request
Feb 22, 2022
davidpdrsn
added a commit
that referenced
this pull request
Feb 22, 2022
taylor1791
added a commit
to taylor1791/axum
that referenced
this pull request
Nov 12, 2022
taylor1791
added a commit
to taylor1791/axum
that referenced
this pull request
Nov 12, 2022
davidpdrsn
pushed a commit
that referenced
this pull request
Nov 14, 2022
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
MethodRouterso it sets theAllowheader when returning405 Method Not Allowed.The header value is built up as a
BytesMutto avoid allocations when creating the response.The header is also set when the fallback is hit, unless the response generated by the fallback already contains the header. This should result in it doing the thing most of the time while allowing users to override it if they handle additional methods in the fallback.
Fixes #731