Fix nesting of opaque services that paths that contain params #841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #830 I discovered that nesting opaque services at paths that contain params was totally broken. Things like
We would try and strip the prefix as
/:a
but thats a placeholder that should match anything. It shouldn't be used as the literal prefix.This required some changes to
StripPrefix
. I also added a bunch more tests and some property tests to get better coverage against panics.