Fix routing for opaque nested services #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
commented
Mar 8, 2022
| let path = if path == "/" { | ||
| format!("/*{}", NEST_TAIL_PARAM) | ||
| let path = if path.ends_with('/') { | ||
| format!("{}*{}", path, NEST_TAIL_PARAM) |
There was a problem hiding this comment.
Before we would add a double slash to nest("/foo/", _).
davidpdrsn
commented
Mar 8, 2022
| @@ -183,7 +199,7 @@ mod tests { | |||
| single_segment_root_prefix, | |||
| uri = "/a", | |||
| prefix = "/", | |||
| expected = None, | |||
| expected = Some("/a"), | |||
There was a problem hiding this comment.
The outcome of this is the same. Not matching the prefix or matching and removing nothing from the path is equivalent.
davidpdrsn
commented
Mar 8, 2022
| uri = "/a/a", | ||
| prefix = "/a/", | ||
| expected = Some("/a"), | ||
| ); |
There was a problem hiding this comment.
Case that wasn't handled properly before.
jplatte
reviewed
Mar 9, 2022
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
jplatte
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #830
This brings nesting of opaque services inline with nesting
Routers, except for one case which is explained in a test. Also added a bunch more comments to the prefix stripping so I'll still be able to understanding it two days from now 😅