Change Handler to have an associated Future type
#879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `#[async_trait]` from `Handler` and replaces that with an associated `Future` type. As hinted at in #878 I'm working on something with types that need to implement `Handler`. I'm doing that by wrapping other `Handler` types so I can implement `Handler` by simply delegating and thus don't need to allocate another box for `#[async_trait]`. This change makes that possible. It does make `Handler` less ergonomic to implement but thats a very niche feature so I'm fine with that. It wouldn't be appropriate for `FromRequest` IMO.
jplatte
reviewed
Mar 21, 2022
jplatte
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
#[async_trait]fromHandlerand replaces that with anassociated
Futuretype.As hinted at in #878 I'm working on something with types that need to
implement
Handler. I'm doing that by wrapping otherHandlertypes soI can implement
Handlerby simply delegating and thus don't need toallocate another box for
#[async_trait]. This change makes thatpossible.
It does make
Handlerless ergonomic to implement but thats a veryniche feature so I'm fine with that. It wouldn't be appropriate for
FromRequestIMO.