Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept &str for Redirect #889

Merged
merged 5 commits into from
Mar 31, 2022
Merged

Accept &str for Redirect #889

merged 5 commits into from
Mar 31, 2022

Conversation

emschwartz
Copy link
Contributor

@emschwartz emschwartz commented Mar 30, 2022

Motivation

http::Uri strips URL fragments, which are important for redirects, for example for login flows with access tokens in the fragment.

Solution

As discussed in #888, this changes the Redirect struct to accept a &str instead of a Uri.

Resolves #888

@jplatte
Copy link
Member

jplatte commented Mar 30, 2022

CI fails because you didn't update the example in the docs for the Redirect type.

Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirects should support URL fragments
3 participants