Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanup #635

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Various cleanup #635

merged 9 commits into from
Oct 2, 2023

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Oct 1, 2023 •
edited
Loading

This performs various cleanup:

  • Factor a lot of panics into functions to improve error messages and reduce codegen.
  • Add missing #[inline] and #[track_caller].
  • Fix some arithmetic overflows in bounds checks.

hds
hds approved these changes Oct 2, 2023
View reviewed changes
Copy link

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. The unsafe section explanations all appear correct. Although I'm not very familiar with this code base, so you might want someone else to have a look too.

@Darksonn Darksonn merged commit fd9243f into master Oct 2, 2023
15 checks passed
@Darksonn Darksonn deleted the alice/patch-01 branch October 2, 2023 13:40
@braddunbar braddunbar mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

@hds hds hds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Darksonn @hds @taiki-e