Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a little refactoring of
split_at
andsplit_to
to remove some extraneous checks and add some clarity around safety guarantees.Each commit is fairly self-contained, but here are the highlights with some rationale:
len
a little more concisely in ea9dd60.split_at
andsplit_to
are doing redundant bounds checking and comparison that I removed in 851b59b and 8381ab7.set_start
toadvance_unchecked
to better reflect it's usage in c70d6d2. I also added some explicit comments about the safety guarantees of that method and an explanation of why each usage is sound.I'm pretty new to this repo, so if I've missed some rules or norms please let me know. I'll be happy to change things up!