Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set len in BytesMut::reserve #682

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Don't set len in BytesMut::reserve #682

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6744316
Don't set `len` in `BytesMut::reserve`
braddunbar Mar 24, 2024
f92c9f6
add debug assertions for len
braddunbar Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/bytes_mut.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,6 @@ impl BytesMut {

// Update the info
self.ptr = vptr(v.as_mut_ptr().add(off));
self.len = v.len() - off;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about asserting that they are equal?

debug_assert_eq!(self.len, v.len() - off);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Added in f92c9f6.

self.cap = v.capacity() - off;
}

Expand Down Expand Up @@ -746,7 +745,6 @@ impl BytesMut {
let data = (original_capacity_repr << ORIGINAL_CAPACITY_OFFSET) | KIND_VEC;
self.data = invalid_ptr(data);
self.ptr = vptr(v.as_mut_ptr());
self.len = v.len();
self.cap = v.capacity();
}

Expand Down