Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct is_unique for Bytes from shared BytesMut #718

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Correct is_unique for Bytes from shared BytesMut #718

merged 2 commits into from
Jul 12, 2024

Commits on Jul 12, 2024

  1. Correct is_unique for Bytes from shared BytesMut 

    The `is_unique` entry in the vtable for `Bytes` created from a shared
`BytesMut` just called the `shared_is_unique` function from the `bytes`
module. However, that function dereferences the `data` argument` as
`bytes::Shared`, but the actual underlying type is `bytes_mut::Shared`.
    @zyxw59 @Darksonn
    zyxw59 authored and Darksonn committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    907b2a1 View commit details
    Browse the repository at this point in the history

  2. add test

    @zyxw59 @Darksonn
    zyxw59 authored and Darksonn committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4fe8b82 View commit details
    Browse the repository at this point in the history