-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests under panic=abort #749
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2781a9f
Add panic=abort workflow
Darksonn 3adf6ff
gate two tests to panic=unwind
Darksonn 2045c71
Ignore instead of cfg out
Darksonn b2ad89e
temp ignore for ci
Darksonn 14d9dbb
Add new script
Darksonn b1e8ef7
Revert "temp ignore for ci"
Darksonn 27a2bf8
add --nocapture
Darksonn 7c83899
tmp restrict test
Darksonn 0a919a3
testing
Darksonn aea9a30
advance
Darksonn 48bb7ae
into_vec
Darksonn eaefd15
into_vec 12
Darksonn 90abfe9
increase ledger
Darksonn acdeb96
rustfmt
Darksonn 3dc8904
Don't need cargo hack
Darksonn 7c0316a
undo debugging
Darksonn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/bash | ||
|
||
set -ex | ||
RUSTFLAGS="$RUSTFLAGS -Cpanic=abort -Zpanic-abort-tests" cargo test --all-features --test '*' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -291,6 +291,7 @@ fn split_to_uninitialized() { | |||||
} | ||||||
|
||||||
#[test] | ||||||
#[cfg_attr(not(panic = "unwind"), ignore)] | ||||||
fn split_off_to_at_gt_len() { | ||||||
fn make_bytes() -> Bytes { | ||||||
let mut bytes = BytesMut::with_capacity(100); | ||||||
|
@@ -1618,6 +1619,7 @@ fn owned_to_vec() { | |||||
} | ||||||
|
||||||
#[test] | ||||||
#[cfg_attr(not(panic = "unwind"), ignore)] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
fn owned_safe_drop_on_as_ref_panic() { | ||||||
let buf: [u8; 10] = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]; | ||||||
let drop_counter = SharedAtomicCounter::new(); | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be additional panic strategies in the future.