Initial query implementation #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hawkw
approved these changes
Jul 29, 2019
| if string.len() < 2 || chars.next() != Some('"') || chars.last() != Some('"') { | ||
| None? | ||
| } | ||
| let inner = &string[1..string.len() - 1]; |
There was a problem hiding this comment.
FWIW, you could also use str::trim_matches here, though just slicing the string is probably faster, as it doesn't require a char comparison.
There was a problem hiding this comment.
The literal/string handling is questionable at best anyways (e.g. doesn't handle escaping), i plan to follow up with the group_by implementation, as it will implement support for the remaining literals, bool, num, and debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #29
Implements a query view + very basic dsl
I've stripped some things out, like span / filter view to get the PR up, we can always add them later on!
It doesn't have nice error messages yet, the buffer will just get cleared and no filter is applied, i will create a follow up issue.
It supports history, via ↑ and ↓
Syntax:
event.field.<message> [== | contains | matches | starts_with] "<value>"Closes #5, #6, #7