fix(subscriber): unset subscriber in aggregator #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the spawned aggregator task in `console_subscriber` to override the default `tracing` subscriber with `NoSubscriber`, which does nothing. This means that any events that occur inside the aggregator task will _not_ be recorded. When instrumentation that the console aggregates is triggered inside the aggregator, it should therefore not cause more data to be recorded. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
it will now never be recorded Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/no-subscriber-aggregator
branch
from
eb762cc to
fc87f5c
Compare
hawkw
force-pushed
the
main
branch
2 times, most recently
from
802ee42 to
c3a7660
Compare
|
I think this work was obsoleted by #314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the spawned aggregator task in
console_subscribertooverride the default
tracingsubscriber withNoSubscriber, whichdoes nothing. This means that any events that occur inside the aggregator
task will not be recorded. When instrumentation that the console
aggregates is triggered inside the aggregator, it should therefore not
cause more data to be recorded.
Signed-off-by: Eliza Weisman eliza@buoyant.io