-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): Support config file #320
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
cc335bf
feat(console): add dependencies
nrskt 4c966b3
feat(console): support config file
nrskt 74a7474
feat(console): main function uses a new parser
nrskt 3a16b75
chore(console): move function to a mehtod.
nrskt 3599796
chore(console): remove clone.
nrskt 99b5f70
chore(console): refactor
nrskt 0847645
feat(console): accept partial config file.
nrskt 222288a
feat(console): add error handling for parsing config
nrskt 1553aaa
chore(console): fix merge logic
nrskt 88307e3
chore(console): fix clippy warnings
nrskt 0e6f9ba
chore(console): print error messsage
nrskt 0a77d61
chore(console): fix config field names
nrskt c87ddfc
chore(console): improve error message
nrskt 2da4fdf
chore(console): fix variant name
nrskt 10113fd
chore(console): improve comments
nrskt 682a261
chore(console): fix ViewOptions::merge_with signature.
nrskt 47ccf21
chore(console): fix visibility.
nrskt d950a98
chore(console): improve method name
nrskt e883cb6
chore(console): improve
nrskt 5ba68c3
Merge branch 'main' into support_config_file
hawkw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last naming nit, take it or leave it: I'm not the biggest fan of calling this
parse
, as it conflicts with theClap::parse
implementation, which is a bit confusing. but, I can't immediately think of a better name for it, so 🤷♀️