Overhaul internals to support faster execution #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internals are overhauled to avoid as much allocation as possible. This is done by leveraging the object store as much as possible and hard coding settings such as max threads. Additionally, the history tracked by atomic cells is limited. These changes enable tracking state without the use of vecs and other allocated collections. The "backtrace" feature is removed in favor of the nightly `Location` API. To enable this, a nightly Rust must be used and `--cfg loom_nightly` specified at compile time. This patch comes with a number of breaking changes, including: * `CausalCell` deferred checks is removed as doing so is undefined behavior. * `CausalCell` is renamed to `UnsafeCell`.
hawkw
reviewed
Mar 12, 2020
|
@hawkw This should be ready to review / merge. |
|
Running this command against the Tokio repo: Master: 631,933 iterations This PR: 231,145 iterations |
hawkw
reviewed
Mar 23, 2020
There was a problem hiding this comment.
The new location tracking is very cool, and I'm excited to get to use it! Bounding the history and using stack arrays seems like a great, simple way to improve loom performance. I'd like to take a closer look at the changes to causality rules, but I've left a few minor comments for now.
hawkw
approved these changes
Mar 23, 2020
Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internals are overhauled to avoid as much allocation as possible.
This is done by leveraging the object store as much as possible and hard
coding settings such as max threads. Additionally, the history tracked
by atomic cells is limited. These changes enable tracking state without
the use of vecs and other allocated collections.
The "backtrace" feature is removed in favor of the nightly
LocationAPI. To enable this, a nightly Rust must be used and
--cfg loom_nightlyspecified at compile time.This patch comes with a number of breaking changes, including:
CausalCelldeferred checks is removed as doing so is undefinedbehavior.
CausalCellis renamed toUnsafeCell.