thread: Add mock versions of thread::park and Thread::unpark
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `loom`'s mock version of `std::thread` does not provide mocked `std::thread::park` or `std::thread::Thread::unpark` APIs. It would be nice to be able to use `loom` to test implementations of synchronization primitives, and other code which uses `thread::park` and `Thread::unpark`. Fortunately, the `loom::rt` internals already contain the necessary primitives to provide simulated versions of these APIs --- they're used internally in the implementation of the mocked `Condvar` and `Notify` types. This branch adds APIs for simulating `thread::park` and `Thread::unpark`. Closes #133
Darksonn
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
loom's mock version ofstd::threaddoes not providemocked
std::thread::parkorstd::thread::Thread::unparkAPIs. Itwould be nice to be able to use
loomto test implementations ofsynchronization primitives, and other code which uses
thread::parkandThread::unpark.Fortunately, the
loom::rtinternals already contain the necessaryprimitives to provide simulated versions of these APIs --- they're used
internally in the implementation of the mocked
CondvarandNotifytypes. This branch adds APIs for simulating
thread::parkandThread::unpark.Closes #133