Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESP-IDF framework support #1692

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

jasta
Copy link
Contributor

@jasta jasta commented Jul 18, 2023

Mostly fixing compiler errors but also working around nonblocking issues with accept, eventfd, etc.

Closes #1691

@jasta
Copy link
Contributor Author

jasta commented Jul 18, 2023

Note that this will conflict with #1687 but with the latest low-churn changes it only conflicts in one trivial place that I can easily fix in either this PR or the other one depending on which one lands first.

src/sys/unix/net.rs Show resolved Hide resolved
src/sys/unix/waker.rs Outdated Show resolved Hide resolved
This was referenced Jul 27, 2023
@Thomasdezeeuw
Copy link
Collaborator

I think this is good to be merged if you can resolve the merge conflict. Afterwards we can open an issue for official support, which would require a maintainer and CI support, etc.

Mostly fixing compiler errors but also working around nonblocking issues
with accept, eventfd, etc.

Closes tokio-rs#1691
@jasta
Copy link
Contributor Author

jasta commented Jul 31, 2023

Ready to rock

@jasta jasta requested a review from Thomasdezeeuw July 31, 2023 18:18
@Thomasdezeeuw Thomasdezeeuw merged commit 236fc31 into tokio-rs:master Jul 31, 2023
19 checks passed
@Thomasdezeeuw
Copy link
Collaborator

Thanks @jasta

@Thomasdezeeuw
Copy link
Collaborator

Opened #1703 for follow ups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ESP-IDF framework support
2 participants