Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up, implement Name trait implementation via prost-build #926

Closed
LucioFranco opened this issue Sep 25, 2023 · 0 comments · Fixed by #931
Closed

Follow up, implement Name trait implementation via prost-build #926

LucioFranco opened this issue Sep 25, 2023 · 0 comments · Fixed by #931

Comments

@LucioFranco
Copy link
Member

Follow up work on #896 to generate the prost-build portion of this implementation. We should generate the impl based on the filedescriptorset values.
This was referenced Sep 25, 2023
Merged
Closed
@tony-iqlusion tony-iqlusion mentioned this issue Oct 3, 2023
Closed
@tinrab tinrab mentioned this issue Oct 11, 2023
Merged
@hdevalence hdevalence mentioned this issue Nov 14, 2023
Closed
redshiftzero added a commit to penumbra-zone/penumbra that referenced this issue Nov 21, 2023
@redshiftzero
deps: update prost to 0.12.2
fbda6c8 
This release of prost includes the support for auto-generated names:

tokio-rs/prost#926
redshiftzero added a commit to penumbra-zone/penumbra that referenced this issue Nov 21, 2023
@redshiftzero
deps: update prost to 0.12.2
30870fd 
This release of prost includes the support for auto-generated names:

tokio-rs/prost#926
redshiftzero added a commit to penumbra-zone/penumbra that referenced this issue Nov 27, 2023
@redshiftzero
deps: update prost to 0.12.2
d03f23b 
This release of prost includes the support for auto-generated names:

tokio-rs/prost#926
redshiftzero added a commit to penumbra-zone/penumbra that referenced this issue Nov 28, 2023
@redshiftzero
deps: update prost to 0.12.2
29c1f3f 
This release of prost includes the support for auto-generated names:

tokio-rs/prost#926
redshiftzero added a commit to penumbra-zone/penumbra that referenced this issue Nov 29, 2023
@redshiftzero
deps: update prost to 0.12.2
8333eaa 
This release of prost includes the support for auto-generated names:

tokio-rs/prost#926
redshiftzero added a commit to penumbra-zone/penumbra that referenced this issue Nov 29, 2023
@redshiftzero
deps: update prost to 0.12.2
38335c3 
This release of prost includes the support for auto-generated names:

tokio-rs/prost#926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Generate implementation for Name trait tinrab/prost
1 participant
@LucioFranco