Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protobuf): protobuf/build.rs get stuck when patch is already applied #1161

Closed
wants to merge 1 commit into from

Conversation

ldm0
Copy link
Contributor

@ldm0 ldm0 commented Sep 17, 2024

protobuf/build.rs is occasionally stucked. The reason is that patch requires user input if the patch has already been applied:

$ patch -p1 -i "../../protobuf/src/fix-conformance_test_runner-cmake-build.patch"
patching file 'cmake/conformance.cmake'
Reversed (or previously applied) patch detected!  Assume -R? [y] 

Adding the -f flag solves the issue.

@caspermeijn
Copy link
Collaborator

On my machine, the command doesn't get stuck on it when the command is run by cargo. But I do occasionally see that output when another build step fails.

I want to update protobuf to a newer version that doesn't require the patch anymore. I expect that to land in a week.

@ldm0 ldm0 closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants