Add enum variant to string mapping

[vriesk]

No description provided.

[vriesk]

@LucioFranco friendly ping :)

[LucioFranco]

Sorry for the delay on this was out on vacation and still suffering from some jetlag. I took a cursory review but would like to spend some more time looking at this. Just wanted to let you know what the status was.

As for one thing, since this adds a method on the generated codegen types. I am leaning that we should just add this not as an opt-in but as a on by default without the config. This would also mean that prost-types would need to be updated and I would like to see that since it will show case some of the codegen.

[vriesk]

Ack, I can remove the config guard. Do you have some specific method to regenerate the prost-types or is it just output of prost-build run?

[LucioFranco]

Its done via a test in bootstrap.rs, basically, when you make a change that changes the output of prost-types generated types the tests fails and updates it. So when you run the test for the second time it will pass. So this will just fail on CI when you haven't checked in the new code.

[vriesk]

Done.

[LucioFranco]

error[E0658]: arbitrary expressions in key-value attributes are unstable
Error: --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/libz-sys-1.1.8/src/lib.rs:115:19
|
115 | #[link_name = zng_prefix!(adler32)]
| ^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #78835 rust-lang/rust#78835 for more information

Looks like libz update is causing msrv issues, will need to investigate this

[LucioFranco]

LGTM! Thanks!

[vriesk]

@LucioFranco I have just noticed that clippy whines about the to_str_name() name:

warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value

Maybe let's change it to as_str_name() then before this gets released? WDYT?

[LucioFranco]

@vriesk good idea, lets do that.