This repository has been archived by the owner on Apr 2, 2018. It is now read-only.
Adds new function interval_range
#33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh I see that the tests are still run for rust 1.14, is this still a valid target? So should I remove the pub(crate)? |
tailhook
reviewed
Oct 12, 2017
src/interval.rs
Outdated
| let mut rng = thread_rng(); | ||
|
|
||
| let secs = rng.gen_range(min.as_secs(), max.as_secs() + 1); | ||
| let nsecs = rng.gen_range(min.subsec_nanos(), max.subsec_nanos() + 1); |
There was a problem hiding this comment.
This doesn't look right. For example if min = Duration::from_millis(1800), max = Duration::from_millis(2900) it will never generate Duration::from_millis(1950) or Duration::from_millis(2100)
There was a problem hiding this comment.
Yeah I see that there is a logic bug, but I don't understand that the values you are given, can not be generated? Even with the bug, these values should be generated.
Edit: Ohh yeah, I see what you mean.
There was a problem hiding this comment.
Thanks for making me aware of this bug :)
The functions returns a `Stream` that fires at some random value, that is in the given range, into the future. The next duration is calculated every time after the Interval fired into the future, by choosing a random value in the given range.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions returns a
Streamthat fires at some random value, that is in thegiven range, into the future. The next duration is calculated every time after
the Interval fired into the future, by choosing a random value in the given range.