fix build and test errors #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After rust-lang/rust#85746 , `ErrorKind::Other` is not what it used to. This library depended on `ErrorKind::Other` in a couple places for error handling, and that's I believe why the tests were failing. I've changed those bits of error handling to rely on the `raw_os_error` instead. This should be more granular than the `kind`, but also more stable. I believe I've chosen the right error codes that we were supposed to handle, and the tests now pass (in my machine anyway lol). I've also changed a couple doc tests that were failing to compile. After these changes, running `cargo test` succeeds.
Darksonn
approved these changes
Dec 31, 2021
Noah-Kennedy
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rust-lang/rust#85746 ,
ErrorKind::Otheris not what it used to. This library depended on
ErrorKind::Otherin acouple places for error handling, and that's I believe why the tests
were failing.
I've changed those bits of error handling to rely on the
raw_os_errorinstead. This should be more granular than the
kind, but also morestable. I believe I've chosen the right error codes that we were
supposed to handle, and the tests now pass (in my machine anyway lol).
I've also changed a couple doc tests that were failing to compile.
After these changes, running
cargo testsucceeds.Fixes: #59