tokio::stream::timeout::Timeout is private

[krojew]

Version

0.2.11

Platform

all

Subcrates

Description

tokio::stream::timeout::Timeout returned by StreamExt::timeout() is private, meaning you can't store the output type anywhere - you can only assign it to a local variable and use type inference, or use dynamic dispatch (which has obvious problems). It's now impossible to store the result e.g. in a struct.

[karlpvoss]

+1 for this, I'd like to be able to store the output type/use it in type definitions.

[karlpvoss]

If this is as simple as marking the module as public I'm happy to do so. Not sure of the implications of that, very new to tokio.

[carllerche]

Thanks for the feedback.

Could you clarify the use cases in which you need to store Timeout in a struct?

[krojew]

@carllerche in my particular case, I have a struct being a stream and a sink, which wraps an underlying stream and sink. The stream is required to time out if it does not receive a message within a given time frame. This is a perfect use case for the stream timeout function, but the result needs to be stored in the wrapper.

[Darksonn]

We discussed this on discord. We would like to make this public, along with the other stream combinators (but not the futures). If you would like to submit a larger PR that marks the combinators as public and puts them in a sub-module of tokio::stream, that would be great!

[Darksonn]

Closing in favor of #2723.