Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokio-stream: Expose Timeout #4599

Closed
madadam opened this issue Apr 5, 2022 · 2 comments
Closed

tokio-stream: Expose Timeout #4599

madadam opened this issue Apr 5, 2022 · 2 comments
Labels
A-tokio-stream Area: The tokio-stream crate C-feature-request Category: A feature request. M-time Module: tokio/time

Comments

@madadam
Copy link
Contributor

madadam commented Apr 5, 2022

I noticed the Timeout struct which is returned from StreamExt::timeout is not public. In my use case I want to create a struct which contains this Timeout as one of its fields but this is currently impossible. Is there a reason this type is not exposed? If not, then I'd be happy to contribute a PR exposing it.
@madadam madadam added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Apr 5, 2022
@Darksonn Darksonn added M-time Module: tokio/time A-tokio-stream Area: The tokio-stream crate and removed A-tokio Area: The main tokio crate labels Apr 6, 2022
@Darksonn
Copy link
Contributor

Darksonn commented Apr 6, 2022

Probably not. There's probably already an issue about this.

madadam added a commit to madadam/tokio that referenced this issue Apr 6, 2022
@madadam
stream: expose Timout (tokio-rs#4599)
581f7ed
@madadam
Copy link
Contributor Author

madadam commented Apr 6, 2022

There's probably already an issue about this

I didn't find one, but maybe I wasn't looking hard enough. Anyway, here is the PR: #4601.

@Darksonn Darksonn closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio-stream Area: The tokio-stream crate C-feature-request Category: A feature request. M-time Module: tokio/time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@madadam @Darksonn