Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundant field names in struct literals #1334

Merged
merged 1 commit into from
Jul 20, 2019
Merged

chore: remove redundant field names in struct literals #1334

merged 1 commit into from
Jul 20, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jul 20, 2019

@carllerche
Copy link
Member

Great 👍. Is there a way to lint this? Maybe we should setup tokio w/ clippy or something?

@carllerche carllerche merged commit 9af07ce into tokio-rs:master Jul 20, 2019
@taiki-e
Copy link
Member Author

taiki-e commented Jul 20, 2019

@carllerche
I think we can use clippy or rustfmt(add use_field_init_shorthand = true to .rustfmt.toml and run cargo fmt -- --check).

Personally, I think it is better to use clippy because it can detect many things. (my recent PRs(#1332, #1333, #1334) are based on clippy).

@taiki-e taiki-e deleted the redundant-field-names branch July 20, 2019 17:56
@carllerche
Copy link
Member

I would be happy to add clippy to CI.

@taiki-e
Copy link
Member Author

taiki-e commented Jul 20, 2019

May I work on it?

@carllerche
Copy link
Member

sure!

@taiki-e taiki-e mentioned this pull request Jul 21, 2019
Merged
@taiki-e
Copy link
Member Author

taiki-e commented Jul 21, 2019

Opened #1335.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @carllerche