chore: bump to newer nightly

.cirrus.yml

@@ -13,7 +13,7 @@ task:
     - pkg install -y curl
     - curl https://sh.rustup.rs -sSf --output rustup.sh
     # TODO: switch back to nightly
-    - sh rustup.sh -y --default-toolchain nightly-2019-07-17
+    - sh rustup.sh -y --default-toolchain nightly-2019-08-01
     - . $HOME/.cargo/env
     - rustup target add i686-unknown-freebsd
     - |

azure-pipelines.yml

@@ -2,13 +2,13 @@ trigger: ["master", "std-future"]
 pr: ["master", "std-future"]
 
 variables:
-  nightly: nightly-2019-07-17
+  nightly: nightly-2019-08-01
 
 jobs:
 # Check formatting
 - template: ci/azure-rustfmt.yml
   parameters:
-    rust: $(nightly)
+    rust: nightly-2019-07-17 # workaround for https://github.com/rust-lang/rustfmt/issues/3725
     name: rustfmt
 
 # Apply clippy lints to all crates

ci/azure-install-rust.yml

@@ -27,8 +27,6 @@ steps:
 
   # All platforms.
   - script: |
-        rustup toolchain install nightly
-        rustup update
         rustup toolchain list
         rustc -Vv
         cargo -V

ci/azure-rustfmt.yml

@@ -9,9 +9,9 @@ jobs:
       parameters:
         rust_version: ${{ parameters.rust }}
     - script: |
-        rustup component add rustfmt
-        cargo fmt --version
+        rustup component add rustfmt --toolchain ${{ parameters.rust }}
+        cargo +${{ parameters.rust }} fmt --version
       displayName: Install rustfmt
     - script: |
-        cargo fmt --all -- --check
+        cargo +${{ parameters.rust }} fmt --all -- --check
       displayName: Check formatting

rust-toolchain

@@ -1 +1 @@
-nightly-2019-07-17
+nightly-2019-08-01

tokio-codec/tests/framed_read.rs

@@ -291,7 +291,7 @@ impl AsyncRead for Mock {
 // TODO this newtype is necessary because `&[u8]` does not currently implement `AsyncRead`
 struct Slice<'a>(&'a [u8]);
 
-impl<'a> AsyncRead for Slice<'a> {
+impl AsyncRead for Slice<'_> {
     fn poll_read(
         self: Pin<&mut Self>,
         _cx: &mut Context<'_>,

tokio-current-thread/src/lib.rs

@@ -430,7 +430,7 @@ impl<P: Park + Default> Default for CurrentThread<P> {
 
 // ===== impl Entered =====
 
-impl<'a, P: Park> Entered<'a, P> {
+impl<P: Park> Entered<'_, P> {
     /// Spawn the future on the executor.
     ///
     /// This internally queues the future to be executed once `run` is called.
@@ -594,7 +594,7 @@ impl<'a, P: Park> Entered<'a, P> {
     }
 }
 
-impl<'a, P: Park> fmt::Debug for Entered<'a, P> {
+impl<P: Park> fmt::Debug for Entered<'_, P> {
     fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
         fmt.debug_struct("Entered")
             .field("executor", &self.executor)
@@ -739,7 +739,7 @@ where
 
 // ===== impl Borrow =====
 
-impl<'a, U: Unpark> Borrow<'a, U> {
+impl<U: Unpark> Borrow<'_, U> {
     fn enter<F, R>(&mut self, f: F) -> R
     where
         F: FnOnce() -> R,
@@ -751,7 +751,7 @@ impl<'a, U: Unpark> Borrow<'a, U> {
     }
 }
 
-impl<'a, U: Unpark> SpawnLocal for Borrow<'a, U> {
+impl<U: Unpark> SpawnLocal for Borrow<'_, U> {
     fn spawn_local(&mut self, future: Pin<Box<dyn Future<Output = ()>>>, already_counted: bool) {
         if !already_counted {
             // NOTE: we have a borrow of the Runtime, so we know that it isn't shut down.
@@ -771,7 +771,7 @@ impl CurrentRunner {
     {
         struct Reset<'a>(&'a CurrentRunner);
 
-        impl<'a> Drop for Reset<'a> {
+        impl Drop for Reset<'_> {
             fn drop(&mut self) {
                 self.0.spawn.set(None);
                 self.0.id.set(None);

tokio-current-thread/src/scheduler.rs

@@ -253,7 +253,7 @@ where
                     node: Option<Arc<Node<U>>>,
                 }
 
-                impl<'a, U: Unpark> Drop for Bomb<'a, U> {
+                impl<U: Unpark> Drop for Bomb<'_, U> {
                     fn drop(&mut self) {
                         if let Some(node) = self.node.take() {
                             self.borrow.enter(|| release_node(node))
@@ -329,7 +329,7 @@ where
     }
 }
 
-impl<'a, U: Unpark> Scheduled<'a, U> {
+impl<U: Unpark> Scheduled<'_, U> {
     /// Polls the task, returns `true` if the task has completed.
     pub fn tick(&mut self) -> bool {
         let waker = unsafe {

tokio-current-thread/tests/current_thread.rs

@@ -380,7 +380,6 @@ mod and_turn {
             },
         );
     }
-
 }
 
 mod in_drop {
@@ -441,7 +440,6 @@ mod in_drop {
             },
         );
     }
-
 }
 
 /*

tokio-executor/src/global.rs

@@ -153,7 +153,7 @@ where
         // when leaving the scope. This handles cases that involve panicking.
         struct Reset<'a>(&'a Cell<State>, State);
 
-        impl<'a> Drop for Reset<'a> {
+        impl Drop for Reset<'_> {
             fn drop(&mut self) {
                 self.0.set(self.1);
             }

tokio-executor/tests/enter.rs

@@ -1,5 +1,5 @@
 #![deny(warnings, rust_2018_idioms)]
-#![feature(await_macro, async_await)]
+#![feature(async_await)]
 
 #[test]
 fn block_on_ready() {

tokio-executor/tests/executor.rs

@@ -1,5 +1,5 @@
 #![deny(warnings, rust_2018_idioms)]
-#![feature(await_macro, async_await)]
+#![feature(async_await)]
 
 use tokio_executor::{self, DefaultExecutor};
 

tokio-io/src/async_buf_read.rs

@@ -31,10 +31,7 @@ pub trait AsyncBufRead: AsyncRead {
     ///
     /// [`poll_read`]: AsyncRead::poll_read
     /// [`consume`]: AsyncBufRead::consume
-    fn poll_fill_buf<'a>(
-        self: Pin<&'a mut Self>,
-        cx: &mut Context<'_>,
-    ) -> Poll<io::Result<&'a [u8]>>;
+    fn poll_fill_buf(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<io::Result<&[u8]>>;
 
     /// Tells this buffer that `amt` bytes have been consumed from the buffer,
     /// so they should no longer be returned in calls to [`poll_read`].
@@ -56,8 +53,8 @@ pub trait AsyncBufRead: AsyncRead {
 
 macro_rules! deref_async_buf_read {
     () => {
-        fn poll_fill_buf<'a>(self: Pin<&'a mut Self>, cx: &mut Context<'_>)
-            -> Poll<io::Result<&'a [u8]>>
+        fn poll_fill_buf(self: Pin<&mut Self>, cx: &mut Context<'_>)
+            -> Poll<io::Result<&[u8]>>
         {
             Pin::new(&mut **self.get_mut()).poll_fill_buf(cx)
         }
@@ -81,10 +78,7 @@ where
     P: DerefMut + Unpin,
     P::Target: AsyncBufRead,
 {
-    fn poll_fill_buf<'a>(
-        self: Pin<&'a mut Self>,
-        cx: &mut Context<'_>,
-    ) -> Poll<io::Result<&'a [u8]>> {
+    fn poll_fill_buf(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<io::Result<&[u8]>> {
         self.get_mut().as_mut().poll_fill_buf(cx)
     }
 

tokio-io/src/io/copy.rs

@@ -33,7 +33,7 @@ where
     }
 }
 
-impl<'a, R, W> Future for Copy<'a, R, W>
+impl<R, W> Future for Copy<'_, R, W>
 where
     R: AsyncRead + Unpin + ?Sized,
     W: AsyncWrite + Unpin + ?Sized,

tokio-io/src/io/flush.rs

@@ -22,7 +22,7 @@ where
     Flush { a }
 }
 
-impl<'a, A> Unpin for Flush<'a, A> where A: Unpin + ?Sized {}
+impl<A> Unpin for Flush<'_, A> where A: Unpin + ?Sized {}
 
 impl<A> Future for Flush<'_, A>
 where

tokio-io/src/io/read.rs

@@ -29,7 +29,7 @@ pub struct Read<'a, R: ?Sized> {
 }
 
 // forward Unpin
-impl<'a, R: Unpin + ?Sized> Unpin for Read<'_, R> {}
+impl<R: Unpin + ?Sized> Unpin for Read<'_, R> {}
 
 impl<R> Future for Read<'_, R>
 where

tokio-io/src/io/read_exact.rs

@@ -40,7 +40,7 @@ fn eof() -> io::Error {
 }
 
 // forward Unpin
-impl<'a, A: Unpin + ?Sized> Unpin for ReadExact<'_, A> {}
+impl<A: Unpin + ?Sized> Unpin for ReadExact<'_, A> {}
 
 impl<A> Future for ReadExact<'_, A>
 where

tokio-io/src/io/shutdown.rs

@@ -22,7 +22,7 @@ where
     Shutdown { a }
 }
 
-impl<'a, A> Unpin for Shutdown<'a, A> where A: Unpin + ?Sized {}
+impl<A> Unpin for Shutdown<'_, A> where A: Unpin + ?Sized {}
 
 impl<A> Future for Shutdown<'_, A>
 where

tokio-io/src/io/write.rs

@@ -22,7 +22,7 @@ where
 }
 
 // forward Unpin
-impl<'a, W: Unpin + ?Sized> Unpin for Write<'a, W> {}
+impl<W: Unpin + ?Sized> Unpin for Write<'_, W> {}
 
 impl<W> Future for Write<'_, W>
 where

tokio-io/tests/lines.rs

@@ -26,10 +26,7 @@ async fn lines() {
     }
 
     impl AsyncBufRead for Rd {
-        fn poll_fill_buf<'a>(
-            self: Pin<&'a mut Self>,
-            _: &mut Context<'_>,
-        ) -> Poll<io::Result<&'a [u8]>> {
+        fn poll_fill_buf(self: Pin<&mut Self>, _: &mut Context<'_>) -> Poll<io::Result<&[u8]>> {
             Poll::Ready(Ok(self.val))
         }
 

tokio-io/tests/read_line.rs

@@ -25,10 +25,7 @@ async fn read_line() {
     }
 
     impl AsyncBufRead for Rd {
-        fn poll_fill_buf<'a>(
-            self: Pin<&'a mut Self>,
-            _: &mut Context<'_>,
-        ) -> Poll<io::Result<&'a [u8]>> {
+        fn poll_fill_buf(self: Pin<&mut Self>, _: &mut Context<'_>) -> Poll<io::Result<&[u8]>> {
             Poll::Ready(Ok(self.val))
         }
 

tokio-io/tests/read_until.rs

@@ -25,10 +25,7 @@ async fn read_until() {
     }
 
     impl AsyncBufRead for Rd {
-        fn poll_fill_buf<'a>(
-            self: Pin<&'a mut Self>,
-            _: &mut Context<'_>,
-        ) -> Poll<io::Result<&'a [u8]>> {
+        fn poll_fill_buf(self: Pin<&mut Self>, _: &mut Context<'_>) -> Poll<io::Result<&[u8]>> {
             Poll::Ready(Ok(self.val))
         }
 

tokio-process/src/kill.rs

@@ -6,7 +6,7 @@ pub(crate) trait Kill {
     fn kill(&mut self) -> io::Result<()>;
 }
 
-impl<'a, T: 'a + Kill> Kill for &'a mut T {
+impl<T: Kill> Kill for &mut T {
     fn kill(&mut self) -> io::Result<()> {
         (**self).kill()
     }

tokio-process/src/unix/orphan.rs

@@ -12,7 +12,7 @@ pub(crate) trait Wait {
     fn try_wait(&mut self) -> io::Result<Option<ExitStatus>>;
 }
 
-impl<'a, T: 'a + Wait> Wait for &'a mut T {
+impl<T: Wait> Wait for &mut T {
     fn id(&self) -> u32 {
         (**self).id()
     }
@@ -31,7 +31,7 @@ pub(crate) trait OrphanQueue<T> {
     fn reap_orphans(&self);
 }
 
-impl<'a, T, O: 'a + OrphanQueue<T>> OrphanQueue<T> for &'a O {
+impl<T, O: OrphanQueue<T>> OrphanQueue<T> for &O {
     fn push_orphan(&self, orphan: T) {
         (**self).push_orphan(orphan);
     }

tokio-signal/examples/multiple.rs

@@ -35,7 +35,6 @@ mod platform {
             println!("received SIGTERM");
         }
     }
-
 }
 
 #[cfg(not(unix))]

tokio-sync/src/mpsc/bounded.rs

@@ -132,7 +132,6 @@ impl<T> Receiver<T> {
     }
 
     /// TODO: Dox
-    #[allow(clippy::needless_lifetimes)] // false positive: https://github.com/rust-lang/rust-clippy/issues/3988
     pub async fn recv(&mut self) -> Option<T> {
         use async_util::future::poll_fn;
 
@@ -205,7 +204,6 @@ impl<T> Sender<T> {
     /// ```
     /// unimplemented!();
     /// ```
-    #[allow(clippy::needless_lifetimes)] // false positive: https://github.com/rust-lang/rust-clippy/issues/3988
     pub async fn send(&mut self, value: T) -> Result<(), SendError> {
         use async_util::future::poll_fn;
 

tokio-sync/src/mpsc/unbounded.rs

@@ -93,7 +93,6 @@ impl<T> UnboundedReceiver<T> {
     }
 
     /// TODO: Dox
-    #[allow(clippy::needless_lifetimes)] // false positive: https://github.com/rust-lang/rust-clippy/issues/3988
     pub async fn recv(&mut self) -> Option<T> {
         use async_util::future::poll_fn;
 

tokio-sync/src/oneshot.rs

@@ -220,7 +220,6 @@ impl<T> Sender<T> {
     /// ```
     /// unimplemented!();
     /// ```
-    #[allow(clippy::needless_lifetimes)] // false positive: https://github.com/rust-lang/rust-clippy/issues/3988
     pub async fn closed(&mut self) {
         use async_util::future::poll_fn;
 

tokio-sync/src/task/atomic_waker.rs

@@ -306,7 +306,7 @@ impl WakerRef for Waker {
     }
 }
 
-impl<'a> WakerRef for &'a Waker {
+impl WakerRef for &Waker {
     fn wake(self) {
         self.wake_by_ref()
     }

tokio-sync/src/watch.rs

@@ -412,7 +412,7 @@ impl<T> Drop for Sender<T> {
 
 // ===== impl Ref =====
 
-impl<'a, T: 'a> ops::Deref for Ref<'a, T> {
+impl<T> ops::Deref for Ref<'_, T> {
     type Target = T;
 
     fn deref(&self) -> &T {

tokio-sync/tests/fuzz_oneshot.rs

@@ -73,7 +73,7 @@ impl<'a> OnClose<'a> {
     }
 }
 
-impl<'a> Future for OnClose<'a> {
+impl Future for OnClose<'_> {
     type Output = ();
 
     fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<()> {

tokio-tcp/src/listener.rs

@@ -124,7 +124,6 @@ impl TcpListener {
     /// ```
     /// unimplemented!();
     /// ```
-    #[allow(clippy::needless_lifetimes)] // false positive: https://github.com/rust-lang/rust-clippy/issues/3988
     pub async fn accept(&mut self) -> io::Result<(TcpStream, SocketAddr)> {
         use async_util::future::poll_fn;
         poll_fn(|cx| self.poll_accept(cx)).await

tokio-threadpool/src/sender.rs

@@ -138,7 +138,7 @@ impl tokio_executor::Executor for Sender {
     }
 }
 
-impl<'a> tokio_executor::Executor for &'a Sender {
+impl tokio_executor::Executor for &Sender {
     fn status(&self) -> Result<(), tokio_executor::SpawnError> {
         let state: pool::State = self.pool.state.load(Acquire).into();