Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp: update API documentation #1392

Merged
merged 1 commit into from
Aug 5, 2019
Merged

tcp: update API documentation #1392

merged 1 commit into from
Aug 5, 2019

Conversation

carllerche
Copy link
Member

No description provided.

@carllerche carllerche requested a review from LucioFranco August 5, 2019 18:26
@carllerche carllerche merged commit 6d8cc4e into master Aug 5, 2019
@95th
Copy link
Contributor

95th commented Aug 8, 2019

This and #1398 is causing Hyper build to fail with:

error[E0599]: no method named `poll_ref` found for type `tokio_sync::watch::Receiver<common::drain::Action>` in the current scope
   --> src/common/drain.rs:102:39
    |
102 |                     match me.watch.rx.poll_ref(cx) {
    |                                       ^^^^^^^^

error[E0624]: method `poll_accept` is private
   --> src/server/tcp.rs:109:48
    |
109 |             match Pin::new(&mut self.listener).poll_accept(cx) {

@carllerche I know you discussed on gitter about making poll_* private and exposing only async methods, but libraries that want to use lower level API and custom polling logic are breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants