update connect example #1787
Merged
update connect example #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yay! Good to have this fixed. Unfortunately, there is a conflict :( would you be able to update? |
jxs
force-pushed
the
update-connect-example
branch
2 times, most recently
from
e199242
to
e073ebb
Compare
|
updated! |
LucioFranco
approved these changes
Dec 18, 2019
jxs
force-pushed
the
update-connect-example
branch
from
e073ebb
to
b18ff9e
Compare
jxs
force-pushed
the
update-connect-example
branch
from
b18ff9e
to
6822b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
example had a run function which was spawned from main function with a oneshot channel to await it's end, due to #1356.
Since #1356 has been addressed, that is no longed needed
Solution
removed run function and moved it's code into the main function, also removed implementation of a bytes coded in favor of
tokio_util::codec::BytesCodec