Fix race condition related bugs #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly pulls in changes from rust-lang/futures-rs#881, but also updates Registration to be a bit more obvious as to what is going on.
This patch adds an ABA guard on token values before registering them with Mio. This allows catching token reuse and avoid the notification. This is needed for OS X as the notification is used to determine that a TCP connect has completed. A spurious notification can potentially cause write failures.
This was referenced Mar 20, 2018
3 tasks
|
I started using this branch for my hyper PR, however I ran into the following error in Travis: (build logs are here: https://travis-ci.org/hyperium/hyper/jobs/356745310) |
|
@srijs Thanks, so the repro is to the test suite on the branch locally? |
|
Ok, I'm going to merge this PR as it is an improvement over master. I opened #248 to track the new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some race conditions.
AtomicTaskis fixed (see Bump tokio-sync v0.1.1 #881).The spurious notifications issue because on OS X
writecannot be called until kqueue returns a notification.