Added get_mut, get_ref and into_inner for Lines.
#2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related issue #2433
Darksonn
added
A-tokio
LucioFranco
approved these changes
Apr 28, 2020
hawkw
requested changes
Apr 28, 2020
|
Thank you for the suggestions @hawkw . Applying it now. |
hawkw
approved these changes
Apr 29, 2020
Darksonn
approved these changes
Apr 30, 2020
Darksonn
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #2433
Motivation
Provides a convenient method to obtain the underlying reader of
Lines.Solution
Implemented
get_mut,get_refandinto_inner. I simply took the implementation from other similar stuffs I see in the code base. Let me know if these are wrong.