Add Handle::spawn_blocking method #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows a similar pattern to `Handle::spawn` to add the blocking spawn capabilities to `Handle`. I took a fairly direct approach to changing the visibilities within the blocking modules to get this to work out, and I would understand if you'd rather have things locked down some more. Please let me know if there are any changes you'd like to see there.
Darksonn
added
A-tokio
|
The motivation definitely makes sense to me 👍 I noticed that the Windows CI tests failed, but I think that was unrelated — I've restarted them, and it looks like they're okay now. I'll take a closer look at the code soon! |
carllerche
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows a similar pattern to
Handle::spawnto add the blocking spawn capabilities toHandle. I took a fairly direct approach to changing the visibilities within the blocking modules to get this to work out, and I would understand if you'd rather have things locked down some more. Please let me know if there are any changes you'd like to see there.Motivation
We have an app with multiple runtimes, so we prefer to perform operations explicitly with handles rather than using the
tokio::task::*spawn operators. However, handles don't currently offer an API to spawn a blocking computation.Solution
Adapts the implementation of
task::spawn_blockingto use the blocking spawner that's already in the handle, guarded bycfg(blocking).