fix use-after-free of Task with futures2 #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aturon |
seanmonstar
commented
Mar 23, 2018
| @@ -1090,7 +1092,6 @@ impl Inner { | |||
| trace!("worker_terminated; num_workers={}", prev - 1); | |||
|
|
|||
| if 1 == prev { | |||
| trace!("notifying shutdown task"); | |||
There was a problem hiding this comment.
Er, woops, did you want to keep this? I was just cleaning up a bunch of logs I had used to debug this, and thought this was one I had added.
This was referenced Mar 24, 2018
3 tasks
|
@seanmonstar do you want me to rebase your PR onto new master? |
|
You can if you want! This has actually been waiting for @aturon to tell us if this breaks some other invariant I didn't consider. |
|
@seanmonstar Sorry for the very delayed review! This PR LGTM. |
kpp
added a commit
to kpp/tokio
that referenced
this pull request
Apr 11, 2018
Code stolen from tokio-rs#254
|
Closing due to inactivity and stagnation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.