Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: always reexport std::io types needed to implement async io traits #2606

Merged
merged 1 commit into from
Jul 24, 2020
Merged

io: always reexport std::io types needed to implement async io traits #2606

merged 1 commit into from
Jul 24, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jun 10, 2020 •
edited
Loading

Motivation

Previously this needed io-util feature, but it doesn't seem to need this limitation.
It also re-exports SeekFrom needed to implement AsyncSeek.

Solution

@taiki-e taiki-e changed the title io: always reexport std::io types that appear in definitions of async io traits io: always reexport std::io types needed to implement async io traits Jun 10, 2020
@taiki-e taiki-e added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Jun 10, 2020
@carllerche carllerche merged commit 7a60a0b into tokio-rs:master Jul 24, 2020
@taiki-e taiki-e deleted the io-reexport branch July 24, 2020 08:11
@Darksonn Darksonn mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @carllerche