Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move StreamReader and ReaderStream into tokio_util #2788

Merged
merged 8 commits into from
Sep 8, 2020
Merged

Move StreamReader and ReaderStream into tokio_util #2788

merged 8 commits into from
Sep 8, 2020

Conversation

Darksonn
Copy link
Contributor

These types are moved because they use the Buf trait in the public api, which we don't want to do for now.

Follow-up to: #2714 (comment)

@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate M-io Module: tokio/io labels Aug 23, 2020
hawkw
hawkw reviewed Aug 27, 2020
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some questions about the tests. Otherwise, this seems good to me!

tokio-util/tests/foo.rs Outdated Show resolved Hide resolved
tokio-util/tests/stream_reader.rs Outdated Show resolved Hide resolved
tokio-util/tests/stream_reader.rs Outdated Show resolved Hide resolved
tokio-util/tests/io_reader_stream.rs Outdated Show resolved Hide resolved
@Darksonn Darksonn requested a review from hawkw August 28, 2020 17:28
xd009642 added a commit to xd009642/tokio that referenced this pull request Aug 29, 2020
@xd009642
Update in preparation for tokio-rs#2788
734f9cf
@Darksonn Darksonn requested a review from LucioFranco August 31, 2020 14:31
LucioFranco
LucioFranco approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions/comments/nits all non-blocking, otherwise LGTM

tokio-util/src/io/reader_stream.rs Outdated Show resolved Hide resolved
tokio-util/src/io/reader_stream.rs Show resolved Hide resolved
tokio-util/src/io/stream_reader.rs Outdated Show resolved Hide resolved
@Darksonn Darksonn merged commit 37f405b into master Sep 8, 2020
@Darksonn Darksonn deleted the reader_stream_master branch September 8, 2020 07:12
@Darksonn Darksonn mentioned this pull request Sep 8, 2020
Merged
@taiki-e taiki-e mentioned this pull request Sep 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

@hawkw hawkw Awaiting requested review from hawkw

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate A-tokio-util Area: The tokio-util crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Darksonn @hawkw @LucioFranco @MikailBag