Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce AsyncFdBuilder #3077

Closed
wants to merge 3 commits into from
Closed

Introduce AsyncFdBuilder #3077

wants to merge 3 commits into from

Conversation

HK416-is-all-you-need
Copy link
Contributor

This is simple draft for builder to allow to configure interest

Fixes #3072

I don't know mio well enough to determine if that's all there to it

@Darksonn Darksonn added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-io Module: tokio/io labels Oct 30, 2020
bdonlan
bdonlan reviewed Nov 2, 2020
View reviewed changes
Copy link
Contributor

@bdonlan bdonlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see an explicit error raised (and associated test) if you attempt to wait for a state you did not request in the builder.

@carllerche
Copy link
Member

I don't think we need to add a Builder type here. We probably can expose our own Interest type and create AsyncFd::new_with_interest(io, interest) or something like that.

Thoughts all?

@HK416-is-all-you-need
Copy link
Contributor Author

Sure, I don't really care how it is done as long as we can configure.
But I don't really have any idea about freebsd behaviour, so I think I'll leave it it someone who can properly test such change

@HK416-is-all-you-need HK416-is-all-you-need deleted the async_fd_builder branch November 3, 2020 05:44
@Darksonn Darksonn mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdonlan bdonlan bdonlan left review comments

@carllerche carllerche Awaiting requested review from carllerche

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncFd doesn't allow to decide read/write interest making kqueue's fd fail in tokio 0.3
4 participants
@HK416-is-all-you-need @carllerche @bdonlan @Darksonn