util: Refactor UdpFramed & add UdpFramedRead/UdpFramedWrite #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leshow
force-pushed
the
udp_framed_read_write
branch
from
71fd35b to
bc66878
Compare
Darksonn
added
A-tokio-util
leshow
force-pushed
the
udp_framed_read_write
branch
from
8713d09 to
8ad5de8
Compare
|
I've added some docs & tests to this. It's the same implementation as before just refactored to be more in line with the other types in |
leshow
force-pushed
the
udp_framed_read_write
branch
2 times, most recently
from
fbd6442 to
bcb5b3e
Compare
leshow
changed the title
|
Sorry, I haven't gotten around to this because it's so long.. |
leshow
commented
Dec 5, 2020
| const INITIAL_WR_CAPACITY: usize = 8 * 1024; | ||
|
|
||
| impl<C: Decoder + Unpin> Stream for UdpFramed<C> { | ||
| impl<C> Stream for UdpFramed<C> |
There was a problem hiding this comment.
Removes Unpin bound-- is this okay?
leshow
commented
Dec 5, 2020
| pub(crate) const INITIAL_RD_CAPACITY: usize = 64 * 1024; | ||
| pub(crate) const INITIAL_WR_CAPACITY: usize = 8 * 1024; | ||
|
|
||
| impl<C, R> Stream for UdpFramedImpl<C, R> |
There was a problem hiding this comment.
Original Stream impl for UdpFramed moved here
|
Oh, that's fine. It looks like a lot of changes but it mostly just shuffles things around to be similar to I added a few comments to the PR that I wanted to call your attention too, but take your time! |
leshow
force-pushed
the
udp_framed_read_write
branch
4 times, most recently
from
8e96d88 to
f73c68b
Compare
leshow
force-pushed
the
udp_framed_read_write
branch
from
f73c68b to
dacfa9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Framedhas both aFramedReadandFramedWrite, it's split up nicely to use the same underlying implementation. This doesn't exist for udpSolution
I basically copied the same style but for
UdpFramed, so that you can make both a Stream-only or Sink-only. It's not totally cleaned up yet, I wanted to get feedback on if this would be accepted first if I keep working on it.I would love to make the underlying type generic and not
UdpSocketor have something generic that bounds over types that implementpoll_send&poll_recv, but unless you're open to adding such a trait, the type will have to be monomorphic, I think.edit: this builds on #3044 so that needs to be merged first