Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: minimal version check (v0.2.x) #3132

Merged
merged 5 commits into from
Nov 12, 2020
Merged

ci: minimal version check (v0.2.x) #3132

merged 5 commits into from
Nov 12, 2020

Conversation

Darksonn
Copy link
Contributor

This checks that crates compile with the minimum allowed version of each dependency.

Backport of #3131

@Darksonn Darksonn added A-ci Area: The continuous integration setup T-v0.2.x Topic: tokio 0.2.x labels Nov 11, 2020
@Darksonn Darksonn changed the base branch from master to v0.2.x November 11, 2020 20:03
@taiki-e taiki-e self-assigned this Nov 11, 2020
@taiki-e
Copy link
Member

taiki-e commented Nov 11, 2020

error[E0599]: no method named drain found for struct slab::Slab<std::thread::JoinHandle<()>> in the current scope
--> tokio/src/runtime/blocking/pool.rs:139:35
|
139 | for handle in workers.drain() {
| ^^^^^ method not found in slab::Slab<std::thread::JoinHandle<()>>

It seems slab's requirement needs to be raised to 0.4.2.
tokio-rs/slab@9c114f0

@Darksonn Darksonn mentioned this pull request Nov 11, 2020
@taiki-e
Copy link
Member

taiki-e commented Nov 11, 2020

error: cannot find macro log in this scope
--> tokio-util/src/codec/framed_impl.rs:215:9
|
215 | trace!("framed transport flushed");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It seems log's requirement needs to be raised to 0.4.6 (or 0.4.4).
rust-lang/log@11dfde1
rust-lang/log@2f52d6c

@Darksonn Darksonn merged commit 1016de2 into v0.2.x Nov 12, 2020
@Darksonn Darksonn deleted the min-ver-0.2.x branch November 12, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup T-v0.2.x Topic: tokio 0.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants