Support aborting a task remotely in a multithreaded runtime without panicking #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udoprog
changed the title
udoprog
changed the title
Darksonn
added
A-tokio
udoprog
force-pushed
the
abort-without-panic
branch
from
8a50232 to
3796df0
Compare
carllerche
approved these changes
Dec 4, 2020
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue in #3157 where a call to
JoinHandle::abortreleases a task, causing a panic because the current implementation ofreleasefor a thread pool requires it to be called from within a worker context.This change makes access of the thread-local context optional under release, by falling back to remotely marking a task as dropped. Behaving the same as if the core was stolen by another worker.
Needs a review by someone familiar with the scheduler, cause I'm not entirely sure I've grok:ed the internals well enough.