-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mio dependency #3207
Upgrade mio dependency #3207
Conversation
Brings in versions of net2 and miow that does not make invalid memory layout assumptions on std::net::SocketAddr
How would this help with the adoption rate? People would pick this up with a |
Because a lot of people never/seldom do |
But if they never cargo update, then they will never pick up this new version of tokio, right? |
Yanking is the mechanism to aggressively pull dependencies forward when necessary. |
I said/meant they never |
Yes I agree. Having all versions of |
@sfackler Do as you see fit. You are the reviewer of the PR on Maybe you can help get all old versions of |
@faern yanking is not a reliable mechanism and IMO should not be employed at this point for this. |
Follow up to tokio-rs/mio#1405. Would probably help greatly with the adoption rate of the fixed versions of
net2
andmiow
. Helps unblock rust-lang/rust#78802. See that PR for more details.