Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: use ReusableBoxFuture for PollSemaphore #3463

Merged
merged 1 commit into from
Jan 30, 2021
Merged

util: use ReusableBoxFuture for PollSemaphore #3463

merged 1 commit into from
Jan 30, 2021

Conversation

robjtede
Copy link
Sponsor Contributor

@robjtede robjtede commented Jan 23, 2021 •
edited
Loading

Motivation

I removed async-stream from the default dep graph in #3366 but it was re-added due to the new PollSemaphore feature. See that PR for rationale.

Solution

Utilising the new ReusableBoxFuture from #3464.

@robjtede robjtede marked this pull request as ready for review January 23, 2021 04:50
@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-sync Module: tokio/sync labels Jan 23, 2021
@Darksonn Darksonn mentioned this pull request Jan 23, 2021
Merged
@robjtede robjtede marked this pull request as draft January 23, 2021 18:29
@robjtede robjtede changed the title util: use hand-written stream for PollSemaphore util: use ReusableBoxFuture for PollSemaphore Jan 23, 2021
@Darksonn
Copy link
Contributor

I just merged the reusable box.

@robjtede robjtede marked this pull request as ready for review January 29, 2021 23:21
Darksonn
Darksonn approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@Darksonn Darksonn merged commit 06d6adf into tokio-rs:master Jan 30, 2021
@robjtede robjtede deleted the poll-semphore-stack branch January 30, 2021 14:18
@Darksonn Darksonn mentioned this pull request Jan 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-sync Module: tokio/sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robjtede @Darksonn