Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix subsequent calls to lines codec decode does not return the desired results #3556

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Bug fix subsequent calls to lines codec decode does not return the desired results #3556

merged 4 commits into from
Feb 25, 2021

Conversation

r-zig
Copy link
Contributor

@r-zig r-zig commented Feb 25, 2021

Motivation

Fix bug on LinesCodec as described here

Solution

return Ok(None) instead of Err(LinesCodecError::MaxLineLengthExceeded)

@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-codec Module: tokio-util/codec labels Feb 25, 2021
Darksonn
Darksonn approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Darksonn Darksonn merged commit 5756a00 into tokio-rs:master Feb 25, 2021
@Darksonn Darksonn mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-codec Module: tokio-util/codec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-zig @Darksonn