time: panic in release when timer polled after completing #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this `debug_assert` could only be [triggered through UB][post] panicking in release mode and including a more helpful error message is nice. Fixes #3675 [post]: https://fasterthanli.me/articles/pin-and-suffering
`compare_exchange_weak` is faster on some platforms but might fail spuriously. That is fine here though since a failure will just mean going through the loop one more time. It was also used elsewhere in `StateCell`'s implementation.
Darksonn
reviewed
Apr 12, 2021
| // | ||
| // In part also to improve the error message for things like | ||
| // https://github.com/tokio-rs/tokio/issues/3675 | ||
| assert!(cur_state < STATE_MIN_VALUE, "timer polled after completing"); |
There was a problem hiding this comment.
Is this the right error message here? Can it actually happen if it is polled after completion too, or does this require moving a pinned Sleep?
|
Ping |
|
Any updates on this? |
|
Ah damnit sorry. I totally forgot about this 😞 Sorry about this. I'll just close this and let someone else fix it. That'll probably be quicker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this
debug_assertcould only be triggered through UBpanicking in release mode and including a more helpful error message is
nice.
Fixes #3675